search

morpho-org / morpho-utils

Repository gathering useful libraries and contracts.
GNU Affero General Public License v3.0
64 stars 1 forks source link

Move Certora helpers to mocks #72

Closed Rubilmax closed 1 year ago

Rubilmax commented 1 year ago

Fixes #71

MathisGD commented 1 year ago

Note that the reason why I did this is because it is classic to have to modify a little bit contracts in order to verify them formally. And it is usually done through a diff file in the Certora folder.

But I don't see any issue with cleaning as you did it.

Rubilmax commented 1 year ago

We should keep all the tests (except gas ones) IMO

You're suggesting to keep the forge tests which are redundant with the Certora tests and remove the tests used to track the gas consumption. The result is:

  1. A developer needs to write the exact same tests twice (once with Certora, once with forge)
  2. We can't track the gas consumption of our library vs the reference library

This is neither what I suggest, nor what @MerlinEgalite suggests. Can you please provide arguments or insights to back your POV?