search

morpho-org / morpho-utils

Repository gathering useful libraries and contracts.
GNU Affero General Public License v3.0
65 stars 1 forks source link

Use forge fmt & lint-staged #84

Closed Rubilmax closed 1 year ago

Rubilmax commented 1 year ago

I think that forge fmt works well, but if we don't use it everywhere it might be annoying no ?

Why would it be annoying?

MathisGD commented 1 year ago

Why would it be annoying?

Because you need to switch the configuration of your IDE each time you change of repo

Rubilmax commented 1 year ago

Because you need to switch the configuration of your IDE each time you change of repo

Fortunately, VSCode & IntelliJ both provide such features And open-source contributors (outside the Morpho Labs team) are used to such changes in setup (because all open-source repositories don't use the same formatter/formatting settings)

Does anyone not use VSCode nor IntelliJ?

MathisGD commented 1 year ago

You mean that you can set a different formatter for each repo on VSCode ? Without the annoying setting file ?

Rubilmax commented 1 year ago

You mean that you can set a different formatter for each repo on VSCode ? Without the annoying setting file ?

Lol no, via the settings file

MathisGD commented 1 year ago

Ok, It's manageable though

Then as you want, but I think that it is easier if we change on all repos