search

morpho-org / morpho-utils

Repository gathering useful libraries and contracts.
GNU Affero General Public License v3.0
65 stars 1 forks source link

De Bruijn - dicho hybrid log2 #94

Closed QGarchery closed 1 year ago

QGarchery commented 1 year ago

For science mainly ^^ hybrid-log2 Just one more gas than the best implementation ! But it probably would not be worth it anyways because of the added complexity of the code

github-actions[bot] commented 1 year ago

Changes to gas cost

Generated at commit: ca83c12f13666a63cfc6990461ae445de61b4cb7, compared to commit: 01b6ead1375e86a472b03abc28beec86d1508c17

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
Full diff report 👇
| Contract | Deployment Cost (+/-) | Method | Min (+/-) | % | Avg (+/-) | % | Median (+/-) | % | Max (+/-) | % | # Calls (+/-) | |:-|-:|:-|-:|-:|-:|-:|-:|-:|-:|-:|-:| | **MathMock contract** | 108,953 (+5,400) | _log2_ | 462 (-14) | **-2.94%** | 462 (-14) | **-2.94%** | 462 (-14) | **-2.94%** | 462 (-14) | **-2.94%** | 2 (0) |
Rubilmax commented 1 year ago

You know the bot is doing its job correctly!!! https://github.com/morpho-dao/morpho-utils/pull/94#issuecomment-1373473939

MathisGD commented 1 year ago

Let's close this one. It is linked to the #12 issue for future reference.