morpho-org / morpho-v1-optimizers-vaults

ERC4626 vaults to ease interaction with Morpho Optimizers.
https://vaults.morpho.org
GNU Affero General Public License v3.0
45 stars 3 forks source link

Rename repo to `morpho-v1-vaults`? #253

Open MerlinEgalite opened 1 year ago

MerlinEgalite commented 1 year ago

This would avoid confusion with morpho-aave-v3 vault and with other vault that we may build later on

pakim249CAL commented 1 year ago

I'm not a fan of changing a public repo name as I simply believe it is a bad practice that can signal that relying on morpho's repos is unreliable. I think it is enough to update the README to be very specific and clear near the top that the vaults are for morpho-v1 only.

MerlinEgalite commented 1 year ago

Well, here I don't think this is a big deal + there are redirections so it will still work + it's a better naming for this repo plus would allow better naming for other repo.

But I agree with your point and don't have a strong opinion on it anyway.

Rubilmax commented 1 year ago

I am ok to change the repo's name as of today. I also understand if we choose to not do so, but then let's name our repository well the first time: tokenized-vaults was obviously a bad name