search

morphometrics / morphometrics-engine

A morphometrics measurement engine
Other
0 stars 1 forks source link

Initial migration #1

Closed kevinyamauchi closed 1 year ago

kevinyamauchi commented 1 year ago

This PR is the initial migration of the measurement engine from morphometrics into a smaller package with few dependencies (see discussion in https://github.com/morphometrics/morphometrics/issues/45 and https://github.com/morphometrics/morphometrics/issues/37)

kevinyamauchi commented 1 year ago

Hey @haesleinhuepf. Here's the initial migration. The goal here is to reproduce the functionality currently in morphometrics (i.e., a "drop in" replacement). After this is in and working, we can then move on to refactoring the API to include surface measurements. I have done some initial testing and I think it works. Would you mind testing this as well?

edit: see the examples/register_measurements.py example

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6799e51). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1 +/- ## ======================================= Coverage ? 93.91% ======================================= Files ? 7 Lines ? 312 Branches ? 0 ======================================= Hits ? 293 Misses ? 19 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morphometrics). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morphometrics)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kevinyamauchi commented 1 year ago

Thanks, @haesleinhuepf ! I have added some tests and things seem to be working, so I will merge. I will make a release soon so you can give it a go!