tferr
commented
1 year ago It is a good idea. A couple of notes:
- I don't really recall why, but IJ's built-in listeners used to intercept keystrokes before any listeners we had (this may have been a bug elsewhere that meanwhile has been fixed, or maybe it was tethered to a specific java/OS version, I really cannot remember). But it made us adopt a dedicated listener: QueueJumpingKeyListener. Maybe this should go there for consistency?
- I feel it is fine to override IJ's File -> Save As -> Tiff... command: I doubt users save the image while tracing since we never modify pixels directly
- We would need to change the documentation, because it says:
SNT was designed so that its shortcuts do not collide with those of ImageJ. SNT hotkeys do not require holding down ⌃ Ctrl / ⌘ .
We are already using S for the cursor snapping. So S alone will not work as-is. Alternatively, we could use Shift+S, but Shift+key combos feel unexpected!? Ctrl/Cmd+ S is such a universal keystroke that it would be a pity not to use it?
carshadi
It would be convenient to press CTRL+S and have the save traces dialog appear. As a rough prototype, I added a key binding to the
PathManagerUIJScrollPanewhich listens for CTRL+S when the window containing the scroll pane is in focus (i.e., when any component ofPathManagerUIis selected), see https://github.com/morphonets/SNT/commit/3e79044d8cb8d1a541f2ba5b7bf46e4ce4eae15aI would pull out the anonymous
AbstractActioninto it's own class, which could then be used by bothSNTUIandPathManagerUIfor saving traces. It seems to work well enough, but I worry that users may get confused since when the image is in focus, CTRL+S opens the image saving dialog instead. They would need to remember to click the Path Manager UI each time.It would probably also make sense to add a listener to the main SNT dialog as well, @tferr what do you think?