search

morphware / service

0 stars 0 forks source link

Handle for bad bid amount edge cases in the `VickreyAuction` contract #23

Open Trabing opened 3 years ago

Trabing commented 3 years ago

bids of 0mwt bids of over bounty make sure they are rejected by the contract

Trabing commented 3 years ago

may need to handle for fractional bounty

Trabing commented 3 years ago

Example:

a bid of 1 MWT on a 10MWT bounty paid 10MWT

bounty: 1mwt reserve: .1mwt bid .25mwt payout: 1.25mwt 2 bidders, each with same bid

Trabing commented 3 years ago

I think there should be a second transfer of auctions[_endUser][_auctionId].secondHighestBid to the data scientist wallet's address

See line 214

@wmantly pointed this out in Discord