search

morris / vanilla-todo

A case study on viable techniques for vanilla web development.
https://morris.github.io/vanilla-todo/
ISC License
1.17k stars 54 forks source link

Suggested Changes implemented #15

Closed sanjay14073 closed 7 months ago

sanjay14073 commented 10 months ago

The changes mentioned were addressed this implies that the workflow will be triggered on pull request of every branch.

morris commented 10 months ago

Thanks for the PR! Does this approach handle the "don't deploy on PRs, only checks" requirement correctly?

sanjay14073 commented 10 months ago

@morris yes since the deploy job needs the check which inturn means that unless the code doesnt pass the checks and only if the pr is on the main branch the workflow will be triggered

sanjay14073 commented 10 months ago

@morris any update.

morris commented 8 months ago

I'm not convinced this fulfills the requirements. It looks like the entire pipeline would be run for every PR 🤔