search

morrisjs / morris.js

Pretty time-series line graphs
http://morrisjs.github.com/morris.js/
6.92k stars 1.23k forks source link

Pie charts #170

Open oesmith opened 11 years ago

oesmith commented 11 years ago

Continued discussion from closed PR #92.

sirNemanjapro commented 10 years ago

What happened to Morris.js? @oesmith

sudodoki commented 10 years ago

So, there're several implementation PRs for Pie Charts in this repo, namely https://github.com/morrisjs/morris.js/pull/92, https://github.com/morrisjs/morris.js/pull/149, https://github.com/morrisjs/morris.js/pull/128. I did use #149, though it had some issues (I commented on PR) and the main flaw is - single label visible at the time, which kind of spoils whole point of pie chart, IMO. Should we kick off this discussion? Maybe, this should not be included as part of v0.5 release.

oesmith commented 10 years ago

Yeah, I'd strongly suggest not adding any new chart types for v0.5 - there's plenty of new code already that needs to be documented and released.

And for pie charts, well, I've yet to see a beautiful pie chart on the web, and none of the attempts for morris.js so far appear to be any better than the norm. :cry:

I'd be very happy if anyone had any good ideas for making pie charts attractive though!

mkramchandra commented 10 years ago

ember charts - pie seems promising.

sudodoki commented 10 years ago

ember charts - pie seems promising.

@mkramchandra are you talking about this one?

mkramchandra commented 10 years ago

yes.

oesmith commented 10 years ago

Even that one seems pretty dull. The pie chart itself is incredibly easy (there's already great examples in g.raphael). The difficult part is getting the labelling or legend to work elegantly, which I don't think ember charts have solved yet, unfortunately.