search

morrislaptop / laravel-elixir-useref

This is a simple wrapper around Laravel Elixir for Useref.
https://www.npmjs.com/package/laravel-elixir-useref
MIT License
11 stars 7 forks source link

Broken in Elixir 2.0 #6

Closed EHLOVader closed 9 years ago

EHLOVader commented 9 years ago

This is now broken in elixir 2.0 because it wasn't properly pinned to a version.

Admittedly Laravel didn't do a good job of documenting the switch, but can you fix your package with a 2.x branch with the current major version, and the old code that worked for Elixir 2.x and bump the major version of your master when you return the code to the current one?

You can see how I did it here https://github.com/EHLOVader/laravel-elixir-livereload/

I also used peerDependencies to prevent installation in the case the wrong version of Elixir was installed for the current version of my package.

EHLOVader commented 9 years ago

Looking at the history I have no clue how this hasn't been a problem for me in the past.

It says you merged the update for Elixir 3.0 many days ago, but it has only just stopped working in my deployment process. Which is a critical problem for me.

morrislaptop commented 9 years ago

Hi Joseph,

Ah I just pushed it up to the NPM repo the other day. I would suggest putting the explicit version number in your package.json so you don't get the updated version.

Cheers, Craig

On Fri, 28 Aug 2015 at 02:21 Joseph Richardson notifications@github.com wrote:

Looking at the history I have no clue how this hasn't been a problem for me in the past.

It says you merged the update for Elixir 3.0 many days ago, but it has only just stopped working in my deployment process. Which is a critical problem for me.

— Reply to this email directly or view it on GitHub https://github.com/morrislaptop/laravel-elixir-useref/issues/6#issuecomment-135597415 .

morrislaptop commented 9 years ago

Also happy for a PR for the peerDependencies, I don't think that was fully established yet when I pushed this library :)

EHLOVader commented 9 years ago

Ah! thanks @morrislaptop it was the npm publish that was done that broke it, I was only looking at the pushes to github (I assumed that if it was pushed it would also have been published)

I can look into writing up a PR. not sure what was fully established? peerDependencies have been around a long while it seems But no fault of yours. The documentation and api change done by Laravel-Elixir was poorly documented and didn't take into account the many plugins that were out there, that the might not all upgrade at once, and that some of their users might not want to upgrade yet.

Adding the explicit version myself. If however you have to support upgrades or api changes in useref for Elixir 2x users you will not have the room to do so. You didn't bump a major version so it might be tricky.