Syntax highlighting without inline styles

[Nessworthy]

Discussion points:

• Client Side vs Server Side
• Choice of Library

Other points to consider:

• User comments and documentation use different highlighters, ideally these will want to be highlighted using the same source.

[kelunik]

It's pretty easy, I'll push something soon.

[morrisonlevi]

It's a private repository but collaborators should have access: https://github.com/kelunik/php-highlight

[kelunik]

We already use class names in the user notes instead of inline styles. Well, kind of pretty hacky. https://github.com/php/web-php/blob/36168258a227b83926341c37eec0c151f8335b6e/include/layout.inc#L14-L49

[Sobak]

Hi!

I'd like to pipe, if I could. As I also thought about that, let me summarise what I found:

1) I'm going to add something like ClientSideHighlighter in next stable version of PhD. A highlighter class which would return valid wrappers possible to be handled by projects like prism.js

2) It will be shameless advertisement of a project written by a friend of mine, but I'd like to mention it, just to get you know what our options are. There is a modern, but also very fast (more than 2x faster than GeSHi on every tested case... if only GeSHi means everything and still can be used as a reference today). https://github.com/kadet1090/keylighter (it has minimal requirement of PHP 5.5 and for why is that important, see below)

3) And now, the sad part comes. PHP version requirements:

• PHP.net mirrors run mostly PHP 5.3 but they are not responsible for running PhD and thus for rendering our code snippets
• PhD is run on about 5 servers from our stock, but there are two we should be interested in (rest of them doesn't render the Manual in web format AFAIK or can still use default highlighter [e.g. PEAR docs])
  • rsync box - this is from mirrors get their built versions of the Manual. I don't know what PHP version it runs, but I doubt it's very old
  • euk2 box (docs.php.net) - in case we want to switch our syntax highlightning, this box needs to have it switched as well, so that we can spot bugs. It runs PHP 5.6.29 as of yesterday. @kadet1090 highlighter's requirement of PHP 5.5 is already met on it. @kelunik's project requires PHP 7, but I believe these requirements can be lowered in case we choose it.
• Highlightning user comments:
  • Each mirrors highlightings them independently so:
    • we choose new-shiny-awesome server-side highlighter for the manual and leave highlight_string() for the manual notes - it would be acceptable IMO, as notes doesn't have any kind of tags enclosing code snippets except for PHP tags. Which are very often unclosed and have text inside. And fixing 25k notes is a no-go. Actually, I don't know about other client-side highlighters but prism.js wouldn't be able to highlight them as well.
    • we choose client side highlighter with its all advantages and disadvantages, but we don't need to care about that anymore

So those are my 2cts (and, yeah, I kinda like nested lists...)