morrissowards / heekscad

Automatically exported from code.google.com/p/heekscad
Other
0 stars 0 forks source link

G83 drill code for EMC (probably others) (in iso.py) causing problems with iso_read.py #359

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Open Heeks, create a point, create drill operation on the point.
2. Click G0 to generate G-Code, fails with "Error Reading End Tag"

What is the expected output? What do you see instead?
Expected GCode, got none in window.

What version of the product are you using? On what operating system?
HeeksCAD 0.18.0 on Windows (7/64bit)

Please provide any additional information below.
Problem as far as I can tell lies in line 116 and 117 of iso.py

Changed from:
    def PECK_DEPTH(self, format, depth): return('Q' + self.SPACE() + (format.string(depth)))
    def RETRACT(self, format, height): return('R' + self.SPACE() + (format.string(height)))

To:
    def PECK_DEPTH(self, format, depth): return('Q' + (format.string(depth)))
    def RETRACT(self, format, height): return('R' + (format.string(height)))

This fixed the problem.  I don't know if spaces are legal or not in G-Code 
syntax between the letter and the number, but iso_read didn't like it and 
another program I have didn't generate a space between the two, so I took the 
space out and it worked.

Original issue reported on code.google.com by bran...@brandonbates.com on 27 Jul 2011 at 4:43