Improve display handling and Makefile

morrolinux / i3expo-ng

Exposè for i3 WM. Fork of https://gitlab.com/d.reis/i3expo to fix crashes and improve features/usability

https://morrolinux.it

MIT License

158 stars 14 forks source link

Improve display handling and Makefile #7

Closed MassimoGirondi closed 3 years ago

MassimoGirondi commented 3 years ago

Hey Ciao!

Some patches to improve the usability:

X11 display handling The primary display can be disconnected (counter-intuitive but it can happen). With the previous solution, if the display was not connected, the program crashed. This patch improve display handling by searching the primary one. If not found as connected, select the first display in the list.
Makefile Automatically compile and install the software with make install. Install the requirements too.
.gitignore and prtscn.so file Adding a compiled library is generally useless since it would need to be recompiled for each machine. Remove it from the tree and avoid to add it again with .gitignore.

morrolinux commented 3 years ago

Neat work! On a side note, ~/.config folder should really be used only for user configurations, so the makefile target install should copy the python files and the screenshot library somewhere else, I'd suggest /opt/i3expo-ng. Also could you add a note in the README explaining that the force option to overwrite previous configuration is suggested if after an update i3expo-ng crashes because of some missing config entries?

Thanks for your contribution

MassimoGirondi commented 3 years ago

On a side note, ~/.config folder should really be used only for user configurations, so the makefile target install should copy the python files and the screenshot library somewhere else, I'd suggest /opt/i3expo-ng.

Why not ~/.local/bin? Seems more appropriate for modern systems and does not require root permissions.

Also could you add a note in the README explaining that the force option to overwrite previous configuration is suggested if after an update i3expo-ng crashes because of some missing config entries?

Done!

morrolinux commented 3 years ago

Why not ~/.local/bin? Seems more appropriate for modern systems and does not require root permissions.

Perfect :)