search

morrolinux / mpradio

Morrolinux's Pirate radio (PiFmRDS / PiFmAdv implementation with Bluetooth and mp3 support) - Stream music to your car's FM radio or use it as a Bluetooth speaker via headphone jack
GNU General Public License v3.0
107 stars 17 forks source link

Moved mpradio executable to /bin/mpradio (system binaries) #27

Closed Hurricos closed 6 years ago

Hurricos commented 6 years ago

This has the effect of avoiding a not-necessarily-obvious collision between the name of the executable and the name of the cloned repository in /home/pi ...

Just a small request. I'm sure it would have a positive effect on newcomers trying things out.

morrolinux commented 6 years ago

Thanks for pointing that out. I should have done it before. However, I think there could be more references to the binary to be changed. Have you checked all scripts? (maybe a recursive grep?) I'll merge as soon as I get back home and test everything works correctly :-) :+1:

Hurricos commented 6 years ago

I did try a recursive grep on 'home', which led me to these couple of occurrences of mpradio. It may be appropriate to move the PiFmRds stuff too, actually, come to think of it.

On Sat, Mar 31, 2018, 07:01 morrolinux notifications@github.com wrote:

Thanks for pointing that out. I should have done it before. However, I think there could be more references to the binary to be changed have you checked all scripts? (maybe a recursive grep?) I'll merge as soon as I get back home and test everything works correctly :-) 👍

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/morrolinux/mpradio/pull/27#issuecomment-377684940, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6GGd7M4alSDO2FaKtwqX7hO0aIvIEDks5tj2IjgaJpZM4TCU2T .

morrolinux commented 6 years ago

Alright, today I should have some spare time to check it out, but I'm pretty sure it will work just fine. As of PiFmRds... yea it would make sense to move it to bin as well.. but maybe only if we can copy just the executable (which I haven't tried as well)