Closed Hurricos closed 6 years ago
That's right, if you can test moving PiFmRds binary to /bin/ (change references in code ect..) would be great. Otherwise I'll do test and do it myself in the next few days I think 👍
I've just had a look at the code. while it's technically possible move the pi_fm_rds executable to /bin/ without issues, there is a quite big reason not to do it:
There is a place for source code, actually ... in reality, /bin
is supposed to only be for binaries that need to be used very early on (in boot); whereas sources packaged with the distribution (Raspbian Minimal, for example) should go to /usr/src
. Now, for the sources which are NOT packaged with the distribution, /usr/local/src
should be the right destination (as per the FHS, referenced in this question).
This is more just a cleanup issue, and it is a bit pedantic. It may be better to wait until you / we have gone through the biggest parts of implementation before touching this -- we can always clean up at the end, after all, since it's just one big cleanup on the one script that does lots of stuff with flies, install/install.sh
.
I could take a swing at this tonight just to close the issue, but it just seems like we're tidying the kitchen before the cooking's done ...
I have completed what I believe is necessary. It could use some more testing, which I will do tomorrow, but feel free to pull in my branch and test it yourself.
Fewer changes are necessary than I suspected. Woohoo!
Thanks man, really appreciated
Just a followup on what you said in response to the initial pull request:
Ideally, as an end user, I would like to be able to
git clone
the repository,cd mpradio && sudo make ./install.sh
, and thensudo rm -rf ~/mpradio ~/PiFmRds
after installation and reboot while retaining full functionality. Really, as the end-user, I probably shouldn't be seeing anything I don't directly need to interact with during runtime in my/home/pi
.That's ideally, of course. It's hardly necessary or even useful, but it would clean up things in the home directory, which is, I guess, a reasonable goal.