morrowdigital / watermelondb-expo-plugin

119 stars 30 forks source link

SDK 48 'Modular Headers' Fix #16

Closed TheLonelyAstronaut closed 1 year ago

TheLonelyAstronaut commented 1 year ago

This small PR fixes #15 - EAS build for SDK48 and WatermelonDB v0.26.0

brunokiafuka commented 1 year ago

Hi @TheLonelyAstronaut thanks for making this fix, will you be able to rebase your branch so we can safely merge.

brunokiafuka commented 1 year ago

One last request please test it under example/* by upgrading the watermelon version on example app.

TheLonelyAstronaut commented 1 year ago

@brunokiafuka are you able to test a plugin by building expo dev client? Looks like it's compiles fine, but when you try to use complex models (with lazy decorators, actions and so on) it just crashes with "undefined is not an object"

brunokiafuka commented 1 year ago

@brunokiafuka are you able to test a plugin by building expo dev client? Looks like it's compiles fine, but when you try to use complex models (with lazy decorators, actions and so on) it just crashes with "undefined is not an object"

I've made a few tweaks but all runs fine, just testing with watermelon v0.26.0

TheLonelyAstronaut commented 1 year ago

@brunokiafuka tested with lazy, its fine. But adding @actions brakes all, could you share example?

brunokiafuka commented 1 year ago

you can branch out the basic starter example on the project here

TheLonelyAstronaut commented 1 year ago

@brunokiafuka huh, sorry, i picked an example from Watermelon repo, it has old library version with deprecated @action hook, all is fine