morrowdigital / watermelondb-expo-plugin

119 stars 30 forks source link

Wasn't able to make it work with Expo v44 and EAS #2

Closed thecoorum closed 2 years ago

thecoorum commented 2 years ago

Hi, first of all, thanks for developing the plugin, but

Description

During development, I met an issue when the project is not built locally with

› Compiling @nozbe/watermelondb Pods/WatermelonDB » std_ext.swift
› Compiling @nozbe/watermelondb Pods/WatermelonDB » DatabaseBridge.swift

❌  (node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/DatabaseBridge.swift:93:13)

  91 |         methodQueue.sync {
  92 |             // swiftlint:disable all
> 93 |             installWatermelonJSI(bridge as? RCTCxxBridge)
     |             ^ cannot find 'installWatermelonJSI' in scope
  94 |         }
  95 |         return [:]
  96 |     }

❌  (node_modules/@nozbe/watermelondb/native/ios/WatermelonDB/DatabaseBridge.swift:103:9)

  101 |                          resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) {
  102 |         var error: NSError?
> 103 |         watermelondbProvideSyncJson(id.int32Value, json.data(using: String.Encoding.utf8.rawValue), &error)
      |         ^ cannot find 'watermelondbProvideSyncJson' in scope
  104 |         if let error = error {
  105 |             sendReject(reject, error)
  106 |         } else {

› Compiling @nozbe/watermelondb Pods/WatermelonDB » Database.swift
› Compiling @nozbe/watermelondb Pods/WatermelonDB » DatabaseDriver.swift

and on EAS it's failing on Fastlane step

My packages

"@nozbe/watermelondb": "~0.24.0",
"expo": "^44.0.0",
"react-native": "0.64.3"
brunokiafuka commented 2 years ago

Unfortunately, we haven’t updated the plugin to work with expo 44 as yet.

Thanks for reporting @thecoorum, will this issue be resolved soon.

Yarkhan commented 2 years ago

FYI This pull request fixes the incompatibility between expo 44 and watermelonDB. It might make this plugin work as well.