search

morrownr / 8821au-20210708

Linux Driver for USB WiFi Adapters that are based on the RTL8811AU and RTL8821AU Chipsets - v5.12.5.2
Other
671 stars 101 forks source link

Typo in DRV_NAME used in install-driver.sh #120

Closed tomasstorck closed 6 months ago

tomasstorck commented 8 months ago

output of sudo uname -mr; mokutil --sb-state; lsusb; rfkill list all; dkms status; iw dev; iw reg get

``` pi@vspp1-fc43f15e:~ $ sudo uname -mr; mokutil --sb-state; lsusb; rfkill list all; dkms status; iw dev; iw reg get 6.1.21-v7l+ armv7l -bash: mokutil: command not found Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub Bus 001 Device 002: ID 2109:3431 VIA Labs, Inc. Hub Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub 0: phy0: Wireless LAN Soft blocked: no Hard blocked: no 1: hci0: Bluetooth Soft blocked: no Hard blocked: no rt8821au, 5.12.5.2, 6.1.21-v7l+, armv7l: installed phy#0 Unnamed/non-netdev interface wdev 0x2 addr e6:5f:01:73:ff:04 type P2P-device txpower 31.00 dBm Interface wlan0 ifindex 3 wdev 0x1 addr e4:5f:01:73:ff:04 ssid spark type managed channel 60 (5300 MHz), width: 80 MHz, center1: 5290 MHz txpower 31.00 dBm global country NL: DFS-ETSI (2400 - 2483 @ 40), (N/A, 20), (N/A) (5150 - 5250 @ 80), (N/A, 23), (N/A), NO-OUTDOOR, AUTO-BW (5250 - 5350 @ 80), (N/A, 20), (0 ms), NO-OUTDOOR, DFS, AUTO-BW (5470 - 5725 @ 160), (N/A, 26), (0 ms), DFS (5725 - 5875 @ 80), (N/A, 13), (N/A) (5945 - 6425 @ 160), (N/A, 23), (N/A), NO-OUTDOOR, AUTO-BW (57000 - 66000 @ 2160), (N/A, 40), (N/A) phy#0 country 99: DFS-UNSET (2402 - 2482 @ 40), (6, 20), (N/A) (2474 - 2494 @ 20), (6, 20), (N/A) (5140 - 5360 @ 160), (6, 20), (N/A) (5460 - 5860 @ 160), (6, 20), (N/A) ``` `mokutil` is not installed on this system, but should not be relevant considering the bug reported here. Let me know if you need this still.

In https://github.com/morrownr/8821au-20210708/commit/7305e07787f5811ee1f5e39818edffa33dcccfb5, the DRV_NAME in install-driver.sh was changed from:

MODULE_NAME="8821au"
DRV_NAME="rtl${MODULE_NAME}"

to:

DRV_NAME="rt8821au"

The prefix rt causes the DKMS module to now end up in (on Raspberry Pi OS) /var/lib/dkms/rt8821au instead of its previous location /var/lib/dkms/rtl8821au, which is inconsistent with what is done in other repositories such as https://github.com/morrownr/rtl8852bu/blob/1.19.3/install-driver.sh.

I propose the DRV_NAME is changed back to a hardcoded rtl8821au.

Edit: proposed fix is implemented in https://github.com/morrownr/8821au-20210708/pull/121