search

morrownr / rtl8852bu

Linux Driver for USB WiFi Adapters that are based on the RTL8832BU and RTL8852BU Chipsets - v1.19.3 - 20230505
Other
97 stars 19 forks source link

(fixed) Improvement to language setting in install script #12

Open kwaaak opened 10 months ago

kwaaak commented 10 months ago

Please use LC_ALL=C instead of LANG=C here for a more robust script https://github.com/morrownr/rtl8852bu/blob/a081fae0039268ef5c7838c428bc8ca0bd6481b1/install-driver.sh#L160C8-L160C47

morrownr commented 10 months ago

Hi @kwaaak

Thanks for the help. Can you tell what problem you were seeing and how this fixed it?

kwaaak commented 10 months ago

Hi, I compiled the driver on a Armbian_23.8.1_Odroidc2_bookworm_current_6.1.50 system with German locale. The script could not read the memory configuration, because the free response was localised. The install script worked fine, I just saw the error messages in the console output. I tried the command manually with LC_ALL=C and the response was in English, which would have let awk match it and populate the variable and so on.

morrownr commented 10 months ago

I really appreciate that you took the time to report this. In your case, it is a cosmetic problem but with low resource systems, it could cause real problems.

The change needed to be made in two places. I have merged the patch.

@morrownr