Open morrys opened 5 years ago
the first renderer is executed by setting the store-only policy
If there is a non-nullable field in the query and it doesn't exist, will the application crash?
Hi @w01fgang, if during the first rendered application the store is empty, the queryrender returns the same result as when the queryrender is loading
hi @bglgwyng, I put the reference to your issue here which seems more appropriate to me. For the moment I would avoid adding other components inside the library, I would prefer as soon as I have time to update the library to the latest version of relay-hooks and relay-runtime The important thing is to understand how to use the restore and use it in the most appropriate way. https://github.com/morrys/wora/issues/138#issue-1809008096
Thanks for the tip 💯
I completely agree that the addition of this feature requires careful consideration.
I believe we might not even require the useRestore
at all. The provided example code for restoring seems sufficient. In my opinion, the current behavior of useRestore
with an updatable Relay environment (using useMemo) appears a bit buggy. This might be due to the inclusion of useState
inside useRestore
. Perhaps allowing programmers to handle the restore logic themselves would be clearer and result in fewer issues.
Example of what happens when using the useQuery/QueryRenderer without useRestore:
Example of what happens when using the useQuery/QueryRenderer with useRestore:
Example of what happens when you use the useQuery/QueryRenderer without useRestore in SSR applications:
In applications with SSR the useRestore should never be used
With the proposed change in relay-hooks, it will be possible to avoid using the useRestore as it will always be possible to perform a forced execution of the QueryFetcher.