search

morse-simulator / morse

The Modular OpenRobots Simulation Engine
http://morse-simulator.github.io/
Other
353 stars 156 forks source link

Fixing weard behavior when a wheeled robot start moving: #644

Closed kellymorse closed 9 years ago

kellymorse commented 9 years ago

Waking up a wheeled robot should not induce any rotation. I removed the rotation value in the impulse that wake up the physical object.

adegroote commented 9 years ago

Looks correct, I don't understand the previous code. Does it fix the issue you report in #637 ?

kellymorse commented 9 years ago

yes, it fixed it, the problem was a rotation value that was added at each time that the physical object is set, Cheers,

On Mon, Jul 27, 2015 at 3:26 PM, Arnaud Degroote notifications@github.com wrote:

Looks correct, I don't understand the previous code. Does it fix the issue you report in #637 https://github.com/morse-simulator/morse/issues/637 ?

— Reply to this email directly or view it on GitHub https://github.com/morse-simulator/morse/pull/644#issuecomment-125204187 .

Khelifa Baizid,

adegroote commented 9 years ago

OK. Perfect. Will merge it when I got proper connection (and not only http stuff).

adegroote commented 9 years ago

Merged in 8a6e319b950b4d3ac9b9f339a25634898ee047b. Thanks.