morse-simulator / morse

The Modular OpenRobots Simulation Engine
http://morse-simulator.github.io/
Other
353 stars 156 forks source link

Port morse-theme to Sphinx 1.3 #652

Closed mitya57 closed 9 years ago

mitya57 commented 9 years ago

In Sphinx 1.3, default theme was renamed to classic, so default/layout.html no longer exists.

adegroote commented 9 years ago

Thanks. It probably fix #650. Anyway, I don't think we can merge as it, as most of supported distribution does not support such recent sphinx distribution (and it is a bit crazy on their side to not keep such kind of compatibility).

mitya57 commented 9 years ago

Yes, #650 is a forwarding of Debian bug filed by me :)

I have uploaded Sphinx 1.3 to Debian unstable some time ago, and will also upload it to Ubuntu when 15.10 is released (and the feature freeze ends).

Upstream indeed broke the compatibility. There are some improvements in the latest git snapshot that partially restore compatibility, but unfortunately they don't bring back the default/layout.html template. I will now ask them whether it's possible to bring that one back too.

adegroote commented 9 years ago

Is https://github.com/adegroote/morse/tree/another_fix_650 not sufficient to fix build for sphinx 1.3 ?

mitya57 commented 9 years ago

@adegroote That works fine for me with 1.3, thanks! I have not tested with 1.2 though.