search

morse-simulator / morse

The Modular OpenRobots Simulation Engine
http://morse-simulator.github.io/
Other
353 stars 156 forks source link

Human avatar rework #682

Closed severin-lemaignan closed 8 years ago

severin-lemaignan commented 8 years ago

A large PR, with quite a bit of rework of the human avatar. See the TODO list in #655 for the main points. To summarize, the new avatar is a robot like any other, with no quirks whatsoever (and it is much more beautiful than before ;-) mesh skinning, yeah!)

The new human avatar is not at feature parity with the old one. Most notably, the 'first person shooter' interface is gone. Re-implementing it is a large undertaking that I fear I'm not going to tackle anytime soon. To prevent clunky co-existence of 2 avatars, I've removed for now all code related to the previous avatar (d4aa865). It would be useful to have feedback from the people currently using the human avatar to see if there is sufficient interest to revive the interactive FPS mode. Note that in #390, we were suggesting to completely remove the FPS mode, and replace it with external scripts.

The PR also contains new unit-tests that should make it much easier to ensure the basic functionalities of the avatar are working.

Happy review!

Fix #192 Partially fix #116, #655, #390, #653 (as the human now use a regular armature, a simple external script interfacing with a kinect would do)

adegroote commented 8 years ago

I probably won't be able to review it properly before 14th.

You should probably send a mail on morse-users@ about usage of 'interactive mode', because most users does not read PR.

adegroote commented 8 years ago

Looks good, and it fixes several issues related to human model in Morse. Interactive part does not seems to be used so much, so not such a big issue. So, for me, you can merge if after fixing the two little remarks.