search

morse-simulator / morse

The Modular OpenRobots Simulation Engine
http://morse-simulator.github.io/
Other
353 stars 156 forks source link

Several ROS related (minor) fixes #688

Closed severin-lemaignan closed 8 years ago

severin-lemaignan commented 8 years ago

Should fix #645

adegroote commented 8 years ago

Looks good, at least from a syntactic point of view (still don't have a ROS environment). We probably can kill ros.helpers as there is no more user. If we do that, it seems there is no more direct reference to rospkg, so do we still need py3-rospkg ?

Another question : do we always need the copy of tfMessage in tree ?

severin-lemaignan commented 8 years ago

@adegroote both your questions are good! To get rid of rospkg would be nice, indeed. I do not see any reason for keeping it, so let's remove it for now.

Regarding tfMessage: the ROS-provided Python bindings for tfMessage.msg (ie, tfMessage.py) are Py3 compliant since a while. But from tf.msg import tfMessage fails for me as the package tf attempts to load a _tf.so that fails with Py3.

So for now, we should keep shipping our own tfMessage even if it is stupid. I've updated it to the current version, though, and I've also added a simple unit-test.

adegroote commented 8 years ago

OK. Nothing to do on the tf side but waiting that Ubuntu and ROS distribute stuff for python3 by default :) Looks good for me to merge. It would maybe nice to add a note in changelog too.

severin-lemaignan commented 8 years ago

Merged! (and one open bug less ;-)