morse-simulator / morse

The Modular OpenRobots Simulation Engine
http://morse-simulator.github.io/
Other
353 stars 156 forks source link

Initial version of the morse_sync tool #689

Closed adegroote closed 8 years ago

adegroote commented 8 years ago

Initial version of morse_sync to handle #683, mostly for discussion.

What to handle yet:

severin-lemaignan commented 8 years ago

For IPC communication, stdin/stdout pipes provided by subprocess wouldn't do?

severin-lemaignan commented 8 years ago

otherwise, the most robust & cross-platform way is probably a pair of TCP sockets...

adegroote commented 8 years ago

Added a man-page, a "parsing" of stdin, and a mechanism to auto-launch it. Please review.

severin-lemaignan commented 8 years ago

Before I review the last commits, see my lenghty comment in #683

adegroote commented 8 years ago

The branch now contains some other time-related commit to Morse, in particular af4b0ae, which fix your issue about frequency handling. I'm now searching the "best default setting" for Morse, but this set of commit should improve a lot the situation anyway. We should hurry a bit if we want to integrate Ubuntu 16.04.

severin-lemaignan commented 8 years ago

One of the issue that makes the whole 'time management' thing difficult to grasp is the vocabulary. So far, we are not very consistent, and not always using the correct terminology. I propose to use the following terminology:

adegroote commented 8 years ago

Handle some of change discussed previously. I also add an 'time_auto_tune', which tries to autoconf Morse time settings (must handle case {1, 3, 4, 5}).

adegroote commented 8 years ago

use_vsync('OFF') use_internal_syncer()

seems a good default, but break some tests. Need to investigate the cause

adegroote commented 8 years ago

After more test, vsync = off + use_internal_syncer + best effort works fine, so I put it in default configuration. vsync_off + use_internal_syncer + fixedtimestep breaks a lot of tests. I'm not sure to understand why. Through, it will an "advanced" settings.

If ok with the current code, I will update the documentation. I'm not sure about the need of 40a850bab6b5fcce954c136ea3cc71828d6182ed now that most scenario are covered automatically.

severin-lemaignan commented 8 years ago

Ok for me to drop 40a850b for now. We'll see if the need arise later.

adegroote commented 8 years ago

I think the branch is complete now. Can you check it a last time before merge ?

adegroote commented 8 years ago

Well, you want I restore the "user part", and I point to the great detail in the dev page :)

severin-lemaignan commented 8 years ago

I guess a user part would make sense, yes :-)

adegroote commented 8 years ago

Does the changes proposed 2 days ago handle your remarks ?

adegroote commented 8 years ago

Just updated last two commits with your comments

severin-lemaignan commented 8 years ago

Then, let's merge it! :-)

adegroote commented 8 years ago

Merged.

severin-lemaignan commented 8 years ago

\o/