search

morse-simulator / morse

The Modular OpenRobots Simulation Engine
http://morse-simulator.github.io/
Other
353 stars 156 forks source link

Cleanup camera and fbo #696

Closed adegroote closed 8 years ago

adegroote commented 8 years ago

I upgraded the branch to consider your remarks. Tell me if it is good for you. Do we merge it now even if fbo stuff is still not in blender master branch ?

PierrickKoch commented 8 years ago

Looks good, I have no time to test today, you can merge, I'll have a better look later this week

severin-lemaignan commented 8 years ago

@adegroote I'm fine with merging (as I'm pretty confident that the upstream changes are going to be merged at some point), but it would be useful to give a bit of context in the commit message (basically, a link to the upstream issue and one sentence about why FBO are useful to us).

Btw, I wonder if we shouldn't mention FBO rendering in the documentation of the VideoCamera sensor as well...

adegroote commented 8 years ago

Btw, I wonder if we shouldn't mention FBO rendering in the documentation of the VideoCamera sensor as well...

I don't think, it is really a detail of implementation (and probably the good / best way to do that in OpenGL :D).

adegroote commented 8 years ago

Merged after edition of the second commit message