search

morse-simulator / morse

The Modular OpenRobots Simulation Engine
http://morse-simulator.github.io/
Other
357 stars 156 forks source link

MOOS new python interface #752

Closed msis closed 7 years ago

msis commented 7 years ago

What is the best practice to update a middleware?

MOOS has now an official interface for python and I want to contribute with a new interface to MORSE, but afraid if I replace the existing one by @davidhodo through a PR, it might ruin legacy code.

Should we have a MOOS2 (or even MOOSv10 as the creator likes to call it) interface in this case?

severin-lemaignan commented 7 years ago

@msis Great to know that MOOS is still used! What kind of breakages do you expect? would this change fundamentally how MORSE interact with MOOS?

I let @davidhodo comment, but if the current user base for MOOS is small (as I suspect), then I would favour just replacing the current implementation with the official moos-python bindings. Carrying over legacy code is not really my cup of tea unless we have solid reasons to do so.

msis commented 7 years ago

In MOOSv10, asynchronous communication with the MOOSDB which allows having callbacks for different messages in addition to the traditional way of getting mail implemented here.

I will be replacing the docs too all along.

davidhodo commented 7 years ago

I am no longer using MOOS with Morse. I'm not sure anyone is maintaining the pyMOOS bindings either. I think replacing the current implementation with something MOOSv10 compatible is the way to go.

David

On Fri, Dec 16, 2016 at 7:48 AM, IBN SEDDIK Mohamed Saad < notifications@github.com> wrote:

In MOOSv10, asynchronous communication with the MOOSDB which allows having callbacks for different messages in addition to the traditional way of getting mail implemented here.

I will be replacing the docs too all along.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/morse-simulator/morse/issues/752#issuecomment-267597578, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3wZiGZnwGXrSmA_B_plpf0Bb4FqTPuks5rIpbEgaJpZM4LOzSX .

severin-lemaignan commented 7 years ago

Ok, thanks @davidhodo for the feedback. @msis please go ahead with a PR, then!

msis commented 7 years ago

Hi guys! I finally had some time to finish the migration and create the PR #757 .