Closed msis closed 7 years ago
Couldn't test, but it looks very good ! Thanks :+1:
Thanks @pierriko , The documentation has been updated accordingly to allow whomever is interested to try and test.
I'm thinking of a way to add unit tests in, but I need the script to install and launch MOOS. Any ideas on how to do that?
You could create a MoosTestCase class. Have a look at this example testing a Sick LiDAR on ROS: https://github.com/morse-simulator/morse/blob/master/testing/middlewares/ros/sick.py using: https://github.com/morse-simulator/morse/blob/master/src/morse/testing/ros.py
That's cool! I will give it a try and create another PR.
@pierriko , I have added a test now. What's the plan now to merge it?
Everything looks good, could you squash the [mw/moos]
commits together (using git rebase -i
) ? Same thing for [testing]
. And remove the merge commit.
Thanks!
I thaught it was good to have different commits so future devs would know how to write their interfaces. I will start rebasing soon. I have an idea about the default publisher that I want to try first. I may include it too. PS: is someone maintaining the tests? a big chunck fails ...
Alright, git rebase
d and tested !
Thanks for accepting the PR!
Merged, Thanks!
This closes #752 .