morse-simulator / morse

The Modular OpenRobots Simulation Engine
http://morse-simulator.github.io/
Other
350 stars 155 forks source link

Debian packaging: ImportError: No module named 'version' #782

Closed severin-lemaignan closed 6 years ago

severin-lemaignan commented 6 years ago

[initially reported by @nicolaje here #766 ]

@dgerod I think this is important for having morse installable via apt-get, see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=867496

but I don't understand what it does.

Also, they mention:

There is still a problem though, because the orig tarball is from the git
tag not the release tarball from
ftp://ftp.openrobots.org/pub/openrobots/morse/ there is no version.py in
the orig and the version reported in version.py is bogus:

mwhudson@scw-4e4aeb:~$ cat x/usr/lib/python3/dist-packages/morse/version.py
VERSION="UNKNOWN-dirty"
PROJECT_STABLE=False

I don't get what/where "the orig tarball from the git tag" is, but shouldn't we add a more recent release on the ftp? 1.4 is 2 years old. @pierriko @adegroote @severin-lemaignan

severin-lemaignan commented 6 years ago

The proper way of fixing the issue is to provide a version.py at the source root of tarball for the stable releases (as the tarball do not include the .git and henceforth, CMake can not automatically calculate the version and generate version.py -- cf details).

That file should only contain:

VERSION = "x.y"
PROJECT_STABLE=True

This has been done correctly for these tarballs for instance:

However, when fetchting the tarball from github directly, this file is absent (as it needs to be manually added).

severin-lemaignan commented 6 years ago

Closing this issue for now.