Use HTTPS instead of HTTP

mortada / fredapi

Python API for FRED (Federal Reserve Economic Data) and ALFRED (Archival FRED)

Apache License 2.0

930 stars 160 forks source link

Use HTTPS instead of HTTP #7

Closed elmotec closed 9 years ago

elmotec commented 9 years ago

Merged 41eaa0b43c5eca7c from master (Factored root url in self.root_url and updated the root url to HTTPS instead of HTTP).
Fixed conflict in test_fred.py by keeping the initial version (theirs). Fixed test as the popularity of releases appears to have changed.

elmotec commented 9 years ago

Hello @mortada, this is the HTTPS-only patch you requested.

I had to look up the git docs and cherry-pick a specific commit from my master branch to my (new) https branch. I hope that's the right way to do this.

mortada commented 9 years ago

This looks good, thanks a lot!

mortada commented 9 years ago

Cherry-picking for this is good. Note that after I merge this PR your other PR will need to be rebased

mortada commented 9 years ago

This is a really minor thing but you might also want to make sure your commit has the same email as the email associated with your GitHub account. This way GitHub can link your commits to your username correctly. You can check that by looking at git config user.email locally