search

mortbopet / Ripes

A graphical processor simulator and assembly editor for the RISC-V ISA
https://ripes.me/
MIT License
2.57k stars 274 forks source link

Fix crash when using extended layout for 5-stage processor. #226

Closed kosayoda closed 2 years ago

kosayoda commented 2 years ago

Prior to this commit, switching to the extended layout for the 5-stage processor would crash Ripes with a 'std::out_of_range' exception caused by map::at. This renders Ripes unusable until processor_layout_id=1 was removed or set to 0 in the configuration as Ripes would also crash on startup.

mortbopet commented 2 years ago

Thank you for reporting this - I can reproduce it locally. Will have a look to find out what's going wrong here!

kosayoda commented 2 years ago

Thank you for reporting this - I can reproduce it locally. Will have a look to find out what's going wrong here!

My PR should fix this issue unless I did something wrong 😅

mortbopet commented 2 years ago

My PR should fix this issue unless I did something wrong 😅

Woops, sorry about that - very used to people submitting issues, and not so used to PRs. Thank you very much, that LGTM!