search

mortbopet / Ripes

A graphical processor simulator and assembly editor for the RISC-V ISA
https://ripes.me/
MIT License
2.49k stars 270 forks source link

Ripes crashes when using 'Open' Syscall #326

Closed lasnikr closed 8 months ago

lasnikr commented 8 months ago

Ripes crashes when using 'Open' Syscall:

li a7, 1024
ecall

This happens with and without arguments and with and without the file actually being present in my testing I am on Mac and on the newest commit (built myself) but I also tried some older commits and saw the same bug. I can't try with the latest release because it is broken on Mac.

raccog commented 8 months ago

@lasnikr This seems to be fixed by #325, which should be pushed to the main branch soon.

325 makes it so that (instead of crashing) ecall will return -1 to the a0 register, showing that it failed.

I'll keep this issue open until the PR is accepted into the main branch, so we can be sure that it fixes the bug.

raccog commented 8 months ago

@mortbopet This issue should be closed; the provided example does not crash anymore on the main branch. It was fixed by #325.