mortbopet / Ripes

A graphical processor simulator and assembly editor for the RISC-V ISA
https://ripes.me/
MIT License
2.49k stars 270 forks source link

Division by zero crash in assembler constant expressions #347

Open Tho-Del opened 5 months ago

Tho-Del commented 5 months ago

If an instruction that takes an immediate has a constant expression with denominator that is evaluated to 0, Ripes will crash from a division by zero evaluation error.

On windows, this error will require system registry edits to recover from, as the simulator loads and assembles the program before it can be edited, and the source code window is stored in the registry. The relevant field is sourcecode in HKEY_CURRENT_USER\Softwware\Ripes\Ripes in the Registry Editor. Setting sourcecode empty or delete the relevant code enables Ripes to run without an instant crash again.

To reproduce:

paste

la x0 0/0

or

start:
la x0 start/start

into Source code in Assembly mode. Upon assembling, Ripes will crash.

Cause:

Ripes/src/assembler/expreval.cpp evaluates assembler constant expression without checking for zero in denominator. Also crashes with modulus % operator.

Tested in Ripes v2.2.6-41, windows 11