mortbopet / VSRTL

Visual Simulation of Register Transfer Logic
MIT License
87 stars 17 forks source link

Before pull-requesting VSRTL on Qt6 #55

Open magiwanders opened 1 year ago

magiwanders commented 1 year ago

On my local copy of the VSRTL repository (updated to latest commit on main) I have migrated the project to Qt 6.5 (beta-1) with no error nor warnings from the compile output, and plan on pull request as soon as:

  1. Qt 6.5 is out of beta
  2. I can run tests on QT Creator. VSRTL seems to work just fine for what I could see from manual testing (after all I have not modified the code, other than refactoring deprecated functions and tweaking cmake files), but actual tests should be run before pull-requesting and I am not familiar with VSRTL testing routine nor QtCreator automated testing. Where can I find more information on how to test VSRTL?
  3. The origin of the runtime error below from Application Output is found. Is this of any concern? How can I test for it?

    qt.dbus.integration: Could not connect "org.freedesktop.IBus" to globalEngineChanged(QString)

This issue is part of the bigger overarching goal of porting Ripes to WebAssembly as described in mortbopet/Ripes#188 . In particular, this is the first step (migrating VSRTL to Qt6).

mortbopet commented 1 year ago

but actual tests should be run before pull-requesting and I am not familiar with VSRTL testing routine nor QtCreator automated testing. Where can I find more information on how to test VSRTL?

Honestly, and i am not proud of this, but the best test of VSRTL is Ripes itself. If the Ripes test suite and UI works, then that's as much confidence as we can have in VSRTL working.