search

mortenjust / androidtool-mac

One-click screenshots, video recordings, app installation for iOS and Android
Apache License 2.0
5.43k stars 325 forks source link

Massive Updates to Android Tool #142

Open muandrew opened 5 years ago

muandrew commented 5 years ago

Hey I just noticed that you accepted my last pull request in October.

Back in Jan of 2018 I thought you abandoned the project and made a bunch of changes on my fork. I don't know if you are interested in taking these changes in or if you were interested in keeping the project alive.

muandrew commented 5 years ago

Just remembered that some of the references to the README was changed to refer to my fork. If you are interested in taking this PR as is just change some of the urls, and references.

mortenjust commented 5 years ago

Hey Andrew, sorry for missing this one. This looks really great! Would be happy to pull. I don't suppose you're experiencing any serious issues with this version? Have you tested with Android P by any chance?

mortenjust commented 5 years ago

Any noteworthy user-visible UX changes I should pay attention to?

muandrew commented 5 years ago

feature: adding a tab for developers to use their own android-sdk. the change prevents adb conflicts between their regular setup and this tool. allowing both to be used side by side. the change required restructuring of the android-sdk binaries.

bugfix: allow a user to see the controls without restarting the app if they dismissed the controls. by pressing the app icon in the dock.

i have validated from my branch that it works with p but my branch didnt include your october change

bugfix: shows the device even if the app was launched after the device is attached.

and a few more small fixes.

i tried getting screenshots to work on ios11 but am not sure if i was actually successful.

most of the changes are described by the title of the commits. if a particular change doesnt make sense just note the commit title and ill explain.

Vlastimilstanik commented 3 years ago

Hey I just noticed that you accepted my last pull request in October.

Back in Jan of 2018 I thought you abandoned the project and made a bunch of changes on my fork. I don't know if you are interested in taking these changes in or if you were interested in keeping the project alive.