search

mortenn / BrowserPicker

Smart browser selector for Windows
MIT License
242 stars 17 forks source link

Load favicon from website, fixes #55 #125

Closed mortenn closed 4 months ago

mortenn commented 4 months ago

Also fixes broken loading window

LB-- commented 4 months ago

It's not obvious from the source here, but can this be disabled with a setting? It's a bit of a privacy issue since normally this app would stop unexpected internet connections being made.

mortenn commented 4 months ago

Yes, this feature respects the "disable network traffic" option which is already there

mortenn commented 4 months ago

I am not entirely happy with the state of this feature though, there are some complications with favicons these days it seems, it's not as simple and easy as it once were :p

mortenn commented 4 months ago

as for privacy concerns, maybe add another setting which defaults to true and only loads favicons from known sites? preconfigured defaults, say?

maybe you'll open an issue to track all this @LB-- ?

LB-- commented 4 months ago

The existing setting sounds good enough to me, I'm not sure it needs to be more complicated than that