mortenn / BrowserPicker

Smart browser selector for Windows
MIT License
244 stars 17 forks source link

Feature Request: Set Default Browser if URL default undefined #68

Closed sl4ppy closed 5 months ago

sl4ppy commented 2 years ago

Add the ability to define a certain browser to open all URL's not defined/overridden by a domain in the defaults list

kissge commented 5 months ago

This feature would be really great! My use case is like: Open Notion in Notion, open Slack in Slack, and otherwise open in Google Chrome.

mortenn commented 5 months ago

Hello, I've just rewritten the configuration part of the app and upgraded it to .NET 8, if you would be so kind as to give this build a try, that'd be great!

kissge commented 5 months ago

Great! I'll give it a try...

Off topic: currently I'm experiencing infinite loop of "You must install or update .NET to run this application" 😐

https://github.com/mortenn/BrowserPicker/assets/4177010/1d60ef8c-2285-48de-91d5-0f76f28893c9

Edit: I was stupid, I think this is because my default browser is set to BrowserPicker

kissge commented 5 months ago

I guess this would be THE functionality we wanted, but couldn't enable it. Maybe I should report this somewhere else?

https://github.com/mortenn/BrowserPicker/assets/4177010/f60e95ac-e3b4-4e83-b8f1-24be4cb12de2

mortenn commented 5 months ago

ah, the check box for enabling it doesn't work, I didn't test that. and I only now realize I neglected to hook up the deletion in the DataGrid

mortenn commented 5 months ago

please try this build

kissge commented 5 months ago

Thanks. This is great work. It's working flawlessly!

// For future readers: apparently Notion.exe necessitates URL rewriting like https://www.notion.so /${PATH} to notion:/${PATH}, so my use case is impossible

mortenn commented 5 months ago

I should be able to add something to support that use case, I am planning on doing the same for teams links eventually :)

mortenn commented 5 months ago

This should be implemented now, let me know if something is missing

sg2002 commented 4 months ago

This does not seem to work for me in the current 2.0.7. The test build posted earlier works though.

mortenn commented 4 months ago

does it work in the latest 2.1 pre-release?

sg2002 commented 4 months ago

No, the latest pre-release does not work either.

mortenn commented 4 months ago

seems to work fine debugging it on my end, what options are you using under behaviour?

sg2002 commented 4 months ago

Ok, here's what I'm observing, because the behavior is very peculiar.

With the following settings:

Using 2.1.3 pretest:

Using the 2.0.0.4 test version from this bug everything works fine. Can it be that it's happening due to some kind of settings incompatibility issue with my old settings breaking the new version? How do I completely delete all BrowserPicker settings to test?

mortenn commented 4 months ago

There is an option that controls whether defaults apply when the configured browser is not running, is that enabled?

mortenn commented 4 months ago

to delete all settings, simply erase HKEY_CURRENT_USER\Software\BrowserPicker from the registry

sg2002 commented 2 months ago

There is an option that controls whether defaults apply when the configured browser is not running, is that enabled?

Right, so that is the issue. If that checkbox is not set, even if Firefox is a pattern-only link handler, that link is not going to open in it, even if Firefox is already running. Does not work if it's the default link handler either.