mortenn / BrowserPicker

Smart browser selector for Windows
MIT License
242 stars 17 forks source link

Settings are not saved #93

Closed Klaster1 closed 5 months ago

Klaster1 commented 1 year ago

How to reproduce:

  1. Install the v2.0-beta3.
  2. Open BrowserPicker from the Windows start menu.
  3. Enable the "Default \ Always user specified browser...".
  4. Click done.
  5. Open BrowserPicker.
  6. Disable the setting, click done.
  7. Open BrowserPicker again.

Expected: The setting is disabled.

Observed: The setting is on.

Notes: Removing browsers from the browser list exhibits the same behavior. Editing the redirect list works as expected.

mortenn commented 1 year ago

Hi, did you try beta 3.1?

Klaster1 commented 1 year ago

The 3.1 does not fix the issue.

coromd commented 1 year ago

I am having the same issue as well on beta 3.1 notepad++_bsO3bo1yGq

mortenn commented 5 months ago

Hello, I've just rewritten the configuration part of the app and upgraded it to .NET 8, if you would be so kind as to give this build a try, that'd be great!

mortenn commented 5 months ago

there were some additional bugs which have been fixed in this build

mortenn commented 5 months ago

I have released v2.0.1 prerelease which hopefully works now :)

mortenn commented 5 months ago

This should be resolved in 2.0.1/2.0.2, let me know if the problem persists.

Deathbot64 commented 5 months ago

On the newest version I am still seeing some issues with settings now fully saving. When No Default is configured matching the url is one setting that will not save.

mortenn commented 5 months ago

Could you please record a video of the issue and open a new issue for that one?

Deathbot64 commented 5 months ago

I found a workaround (I think anyways) to get it working. I uninstalled 2.0.6. Then installed 2.0.1, updated the setting there which worked. Then updated to 2.0.6 and now the setting seems to save even after changing browser. But I havent tried to disable it again yet. I also do not see a key in the registry settings for this setting.

mortenn commented 5 months ago

I am not sure which setting you are referring to

Deathbot64 commented 5 months ago

Screenshot 2024-04-04 181443 This one

mortenn commented 5 months ago

Ah, I see. I wasn't really expecting anyone to use that one without any defaults, as doing so basically just makes BrowserPicker not do anything other than launching your one browser.

That setting gets saved as the (default) value in the registry image