search

mortensimon / web

MIT License
3 stars 11 forks source link

Protocol defaults to N/A even when already configured. #8

Closed thorsager closed 8 years ago

thorsager commented 9 years ago

Protocol defaults to 'N/A' under 'Unit Type Configuration' even if Protocol has been selected on the specific Unit Type.

This could cause the protocol to be updated to 'N/A' if 'Vendor' or 'Description' is changed, which in turn disables the TR-111 Kick functionality.

Note: This is NOT a major bug, but I just ran into it, and wanted to make a note..

Anyway thanks for the great work :+1:

jarlah commented 8 years ago

I will check this. Most likely a simple bug.

jarlah commented 8 years ago

aha ... the protocol is stored in database as TR069 which is wrong. It should be TR-069 +--------------+------------+----------------+-------------+-------------+----------+ | unit_type_id | matcher_id | unit_type_name | vendor_name | description | protocol | +--------------+------------+----------------+-------------+-------------+----------+ | 1 | NULL | Some Test | NULL | Test | TR069 | +--------------+------------+----------------+-------------+-------------+----------+ Or the other way around. It should be TR069 in the interface. I dunno

jarlah commented 8 years ago

I removed OPP from the protocol select dropdown on the create unit type page. Since OPP is not a valid dropdown value on unit type details page, OPP would never been displayed.

Can be merged