Remember the Readability Report Generator settings - Githubissues

mortii / anki-morphs

A MorphMan fork rebuilt from the ground up with a focus on simplicity, performance, and a codebase with minimal technical debt.

https://mortii.github.io/anki-morphs/

GNU Affero General Public License v3.0

62 stars 9 forks source link

Remember the Readability Report Generator settings #147

Closed aleksejrs closed 3 months ago

mortii commented 9 months ago

Per session or persistent between sessions too?

aleksejrs commented 9 months ago

I haven't considered using different frequency lists and therefore different corpora in it, so persistent. If I do change it all the time, it will still be good if it remembers what I was looking at last time, even though I have a bookmark for the main corpus in the Open window.

mortii commented 9 months ago

sure, this is a nice QOL upgrade.

mortii commented 9 months ago

It probably makes sense to store all the settings (extensions, preprocessing, etc), and not just the input dir.

I think this makes a lot of sense for the RRG since I imagine someone might want to run it every day, but the FFG usage is probably less frequent, so I'm not sure there is much to gain with storing the previous settings for it.

Thoughts @aleksejrs ?

aleksejrs commented 9 months ago

Sure, all those settings are important to those who use them. I always considered readability just a nice addition to the frequency list generation. FFG has a greater impact on the learning process, so its settings seem more important, but if anybody uses the settings in RRG often, they will also want the output to be consistent.

mortii commented 9 months ago

I'll make the RRG settings persistent first, then maybe do the same for the FFG later.

aleksejrs commented 9 months ago

On the other hand, the persistence of the frequency.csv file can lead to accidental overwriting if you use multiple files. A history dropdown might help.

mortii commented 9 months ago

On the other hand, the persistence of the frequency.csv file can lead to accidental overwriting if you use multiple files. A history dropdown might help.

A history drop down would be overkill I think. Cool idea though.

mortii commented 8 months ago

The generators' settings will be very volatile for a while, so I'll wait a little longer to implement this.

mortii commented 3 months ago

@aleksejrs @Gardengul

you guys want all the settings to be saved and not just the preprocessing ones, right?

aleksejrs commented 3 months ago

@mortii, yeah. It seems obvious to me that the settings that are not changed every time should be saved.

"Add occurrences column" only affects the user (and whatever the user processes them with, but it is already a format specific to AM?), and why would the user want different ones for different lists?
"Lemma and inflection" vs "Lemma" is related to a global setting in AM (and does not depend on it), so it is unlikely to be changed. I use the default "Lemma and inflection" though.

mortii commented 3 months ago

@aleksejrs could you help test it?

Either pull the extra-settings branch or use this .addon file.

mortii commented 3 months ago

released in v3.1.0

github-actions[bot] commented 2 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.