search

mortii / anki-morphs

A MorphMan fork rebuilt from the ground up with a focus on simplicity, performance, and a codebase with minimal technical debt.
https://mortii.github.io/anki-morphs/
Mozilla Public License 2.0
46 stars 6 forks source link

Remember the Readability Report Generator settings #147

Open aleksejrs opened 5 months ago

mortii commented 5 months ago

Per session or persistent between sessions too?

aleksejrs commented 5 months ago

I haven't considered using different frequency lists and therefore different corpora in it, so persistent. If I do change it all the time, it will still be good if it remembers what I was looking at last time, even though I have a bookmark for the main corpus in the Open window.

mortii commented 5 months ago

sure, this is a nice QOL upgrade.

mortii commented 5 months ago

It probably makes sense to store all the settings (extensions, preprocessing, etc), and not just the input dir.

I think this makes a lot of sense for the RRG since I imagine someone might want to run it every day, but the FFG usage is probably less frequent, so I'm not sure there is much to gain with storing the previous settings for it.

Thoughts @aleksejrs ?

aleksejrs commented 5 months ago

Sure, all those settings are important to those who use them. I always considered readability just a nice addition to the frequency list generation. FFG has a greater impact on the learning process, so its settings seem more important, but if anybody uses the settings in RRG often, they will also want the output to be consistent.

mortii commented 5 months ago

I'll make the RRG settings persistent first, then maybe do the same for the FFG later.

aleksejrs commented 5 months ago

On the other hand, the persistence of the frequency.csv file can lead to accidental overwriting if you use multiple files. A history dropdown might help.

mortii commented 5 months ago

On the other hand, the persistence of the frequency.csv file can lead to accidental overwriting if you use multiple files. A history dropdown might help.

A history drop down would be overkill I think. Cool idea though.

mortii commented 3 months ago

The generators' settings will be very volatile for a while, so I'll wait a little longer to implement this.