changing notetype produces strange results

[fuquasteve]

Describe the bug

I messed my ankimorphs deck up a bunch. I don't know if this would be considered a bug, or if it is just something that should be warned about, perhaps in the documentation.

I changed the order of the fields in my notetype. When I did a recalc, the results were strange, and clearly incorrect. I suspect that I should have just made a new row for my modified notetype and then things would have just worded.

Expected behavior

ankimorphs should have read the fields in the changed order and produced logical results.

Screenshots

My setup

• Operating System:Linux (Manjaro)
• Anki Version:Version ⁨23.12.1 (1a1d4d54)⁩ Python 3.11.8 Qt 6.6.2 PyQt 6.6.1
• AnkiMorphs Version:2.2.0

Additional context

My deck I am analyzing and modifying with ankimorphs is ridiculously big, 309 000 cards, if this effects anything.

Perhaps this should just be a warning in the documentation, or moving the warning I didn't find to a more prominent position

I set off a cascade of errors with my attempts to correct this problem. There was an easy fix that I finally figured out. I will submit a simple enhancement request that I wish I had had.

[mortii]

Oh wow, that is really, really bad.

This is caused by the settings saving the index of the field instead of always looking it up based on the name/title. I'll fix it asap!

There was an easy fix that I finally figured out. I will submit a simple enhancement request that I wish I had had.

One easy fix right now would be to just save the note filter settings again after you have finished changing the fields of your cards, that way the field index is correct again.

[mortii]

I'm going to do this:

• [x] add a (none) option to the QComboBoxes in the settings:
  • [x] note type
  • [x] field
  • [x] morphemizer
  • [x] morph priority
• [x] set the default options to (none)
• [x] set the options to (none) if the stored options are no longer found
• [x] don't store the indices of the selected options
• [x] don't store the note_type_id
• [x] don't store the morphemizer_name
• [x] dynamically find the indices on recalc
  • [x] note_type_id
  • [x] morphemizer_name
  • [x] expression field
  • [x] morph priority
• [x] abort recalc if indices are not found
• [x] abort recalc if (none) is found
• [x] tests
  • [x] manually test
    • [x] reordering fields
    • [x] deleting the field
    • [x] deleting note type
    • [x] deleting frequency file
    • [x] deleting morphemizer
    • [x] adding new extra fields
    • [x] adding new note filter rows
  • [x] add unit tests
  • [x] make sure it doesn't break backwards compatibility
• [x] deep cleaning

[mortii]

@fuquasteve should be fixed in v2.2.3.

Thanks!

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.