mortii / anki-morphs

A MorphMan fork rebuilt from the ground up with a focus on simplicity, performance, and a codebase with minimal technical debt.
https://mortii.github.io/anki-morphs/
Mozilla Public License 2.0
47 stars 6 forks source link

option to remove tags that ankimorphs uses. #209

Open fuquasteve opened 3 months ago

fuquasteve commented 3 months ago

Is your feature request related to a problem?

As part of a clumsy attempt to fix a messed up anki deck, that was showing nonsensical results, I ran the wrong morphemizer on my deck, which found zero morphs in the deck and which tagged every single card with am-known-automatically. This produced results where ankimorphs claimed that I knew 19000 morphs, which is not the case.

Describe the solution you would like

I would like a way to remove tags that ankimorphs uses if the user messes them up

Describe alternatives you've considered

an option to remove all of the tags would be nice

Additional context

My deck is huge and highlighting and removing the tags manually is very slow

mortii commented 3 months ago

Sure, we could add a "Remove all AnkiMorphs tags from all cards" option. Where would you want it?

P.S: Whenever I had to do this, I just selected all the cards in the browser -> right click the tag in the left hand sidebar -> "Remove from selected notes"

fuquasteve commented 3 months ago

Maybe next to the restore defaults button. Or perhaps on the ankimorph tags page.

On Thu, Apr 4, 2024, 11:47 AM mortii @.***> wrote:

Sure, we could add a "Remove all AnkiMorphs tags from all cards" option. Where would you want it?

— Reply to this email directly, view it on GitHub https://github.com/mortii/anki-morphs/issues/209#issuecomment-2037955183, or unsubscribe https://github.com/notifications/unsubscribe-auth/APG7PUJURNAB2MSK2H6COXTY3WN3DAVCNFSM6AAAAABFXYWJB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZXHE2TKMJYGM . You are receiving this because you authored the thread.Message ID: @.***>

fuquasteve commented 3 months ago

Do the ankimorph fields need to be cleared too to recover from running the wrong morphemizer? I don't think so...

On Thu, Apr 4, 2024, 12:08 PM stephen fuqua @.***> wrote:

Maybe next to the restore defaults button. Or perhaps on the ankimorph tags page.

On Thu, Apr 4, 2024, 11:47 AM mortii @.***> wrote:

Sure, we could add a "Remove all AnkiMorphs tags from all cards" option. Where would you want it?

— Reply to this email directly, view it on GitHub https://github.com/mortii/anki-morphs/issues/209#issuecomment-2037955183, or unsubscribe https://github.com/notifications/unsubscribe-auth/APG7PUJURNAB2MSK2H6COXTY3WN3DAVCNFSM6AAAAABFXYWJB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZXHE2TKMJYGM . You are receiving this because you authored the thread.Message ID: @.***>

xofm31 commented 3 months ago

I have been tripped up by the tags several times, and now that I know it, I just delete the tags. But the first time, I was certain there was something wrong with AnkiMorphs. So I would suggest that whenever somebody does something likely to cause an issue (such as changing the morphemizer), either asking the user if they want to delete the tags, or at least giving a suggestion to do so. Also, if you create an option to remove the tags, I'd label it as something that might help if you feel that AnkiMorphs has messed up your known morphs. Or highlight it in your user guide.

mortii commented 3 months ago

Do the ankimorph fields need to be cleared too to recover from running the wrong morphemizer?

@fuquasteve no, shouldn't be necessary.

I would suggest that whenever somebody does something likely to cause an issue (such as changing the morphemizer), either asking the user if they want to delete the tags, or at least giving a suggestion to do so.

@xofm31 great idea. Implementing that could get really messy, but I will definitely keep it in mind.

Also, if you create an option to remove the tags, I'd label it as something that might help if you feel that AnkiMorphs has messed up your known morphs. Or highlight it in your user guide.

For sure. I might make a new dialog for resetting stuff to provide more granular options, but I'm haven't decided yet.