search

mortii / anki-morphs

A MorphMan fork rebuilt from the ground up with a focus on simplicity, performance, and a codebase with minimal technical debt.
https://mortii.github.io/anki-morphs/
Mozilla Public License 2.0
47 stars 6 forks source link

The "Cancel" button in Settings is confusing. #212

Closed aleksejrs closed 2 months ago

aleksejrs commented 3 months ago

Describe the bug

The Save button saves, but does not close the window. You have to press Cancel to close the window. It does not undo what you saved. However, it does reject any changes you didn't save, so just renaming it to Close might not be perfect. Maybe making Save close the window would make it less confusing.

My setup

mortii commented 3 months ago

You're right, it is pretty confusing... we could potentially enable/disable it based on if any changes have been made, would that be better?

Edit:

Maybe making Save close the window would make it less confusing.

This approach could get really annoying for users that save every time they make changes in a tab before they move on to the next one.

Edit 2: How about just removing the "cancel" button and instead give a warning when someone tries to close the window without saving any changes?

mortii commented 2 months ago

The future implementation is described here: https://github.com/mortii/anki-morphs/discussions/218#discussioncomment-9109229, so I'll close this issue.

github-actions[bot] commented 2 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.