search

mortii / anki-morphs

A MorphMan fork rebuilt from the ground up with a focus on simplicity, performance, and a codebase with minimal technical debt.
https://mortii.github.io/anki-morphs/
Mozilla Public License 2.0
47 stars 6 forks source link

words separated by <br> are joined #241

Closed aleksejrs closed 4 weeks ago

aleksejrs commented 1 month ago

Describe the bug

AMBR

My system

Additional context

IIRC, I had thought MorphMan got plain text from Anki, which did not contain the <br>. But somebody said (about a later version) that the problem was in the regexp. FrequencyMan removes the HTML code itself; the dev just forgot to include <br> in the list of tags to replace with a space: https://github.com/Rct567/FrequencyMan/issues/6

mortii commented 1 month ago

Yep, this is known (#124).

There is a Morphs don't split on punctuation marks section in known problems with how to fix it. That one-time fix is much better than stripping the text on every recalc imo.

Thanks for the heads up though, appreciate it :+1:

aleksejrs commented 1 month ago

These pages suggest using it for poems and addresses (with no extra spaces): https://www.w3.org/TR/2011/WD-html5-author-20110809/the-br-element.html https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br https://www.w3schools.com/tags/tag_br.asp

Pressing Enter in the note editor adds a <br> (at least unless you do after an existing div or an HTML list). movies2anki turns line breaks in subtitles into <br> and/or joins lines with it.

The lines do not always end in a period, so a user capable of pressing Enter or using movies2anki needs careful use of regular expressions to fix it.

mortii commented 1 month ago

The issue is that \
is relatively rare, so checking and/or substituting for it potentially hundreds of thousands of times every recalc is super inefficient. Using the native search and replace feature is much better imo.

The lines do not always end in a period, so a user capable of pressing Enter or using movies2anki needs careful use of regular expressions to fix it.

That's true, I'll update the header in the guide to something more generic.

mortii commented 4 weeks ago

I change the section in known problems to "Morphs don't split correctly", and I changed the find and replace terms to make them more generic.

Let me know if it doesn't work :)

github-actions[bot] commented 3 weeks ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.