search

mortii / anki-morphs

A MorphMan fork rebuilt from the ground up with a focus on simplicity, performance, and a codebase with minimal technical debt.
https://mortii.github.io/anki-morphs/
Mozilla Public License 2.0
47 stars 6 forks source link

Improve visual cues in the generator window #249

Open aleksejrs opened 2 weeks ago

mortii commented 2 weeks ago

The relevant settings being file formats?

aleksejrs commented 2 weeks ago

Whatever setting you need to click Load Files after? So Folder and file formats sure, if nothing else affects how they are loaded.

mortii commented 2 weeks ago

That would be disastrously bad if you have a large file tree. Say you have 1M files under a directory, if you want to unselect three file formats, you would then needlessly reload millions of files...

Loading the files at your own discretion is generally much preferable, in my opinion.

aleksejrs commented 2 weeks ago

Maybe make the button red/orange when the files were not loaded with the current settings?

And since the button will become more prominent, perhaps move it so that "Select Folder [__]" takes the whole row, and only the "Morphemizer" and "File formats" lines are reduced by it, and the button will be closer to the center and the other buttons.

mortii commented 2 weeks ago

Maybe make the button red/orange when the files were not loaded with the current settings?

Giving more visual cues is a good idea. It might be sufficient to just disable/enable the "load files" button.

And since the button will become more prominent, perhaps move it so that "Select Folder [__]" takes the whole row, and only the "Morphemizer" and "File formats" lines are reduced by it, and the button will be closer to the center and the other buttons.

I tried different layouts when I made it, but they all ended up looking worse than the current one. If you can sketch out a better layout then I'll happily look at it.