search

mortii / anki-morphs

A MorphMan fork rebuilt from the ground up with a focus on simplicity, performance, and a codebase with minimal technical debt.
https://mortii.github.io/anki-morphs/
Mozilla Public License 2.0
55 stars 8 forks source link

'Learn card now' browser action does not update seen morphs #27

Closed mortii closed 10 months ago

Vilhelm-Ian commented 10 months ago

Couldn't somebody just mass select and press add tag "am_known" and recalculate

Vilhelm-Ian commented 10 months ago

We could just make the Learn card now button just do that instead of changing it to a review and changing it's due value

Vilhelm-Ian commented 10 months ago

I just realized why it dosen't work anymore. IT has to do with the query I wrote. It checks "introduced:1" meanning that the card must be answered the same day. 

#   "(introduced:1 note:ankimorphs\_sub2srs OR introduced:1 note:Basic) OR is:buried tag:am-known"

so we should bury the card and tag it as am-known

mortii commented 10 months ago

Sorry, I typed the wrong thing in the title, I meant 'learn card now'

mortii commented 10 months ago

Another thing i think happens is that the 'learn card now' places the card at position 0 in the queue, which means it is not actually shown. Not sure though, I need to investigate it more in-depth first.

Edit: It happened because the card I clicked 'learn card now' on was in a different deck than the one I was currently studying. This might be worth putting in the FAQ.

mortii commented 10 months ago

we should bury the card and tag it as am-known

No, that would unfortunately mark all the morphs on the card as known which would make the highlighting wrong...

mortii commented 10 months ago

I suspect there is a really simple solution to this like just setting 'mw.reviewer.card = card' in run_learning_card_now()

Edit: the problem does seem to be mw.reviewer.card.id not updating to the new card when 'learn card now' is used

mortii commented 10 months ago

fixed in #29

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.