mortii / anki-morphs

A MorphMan fork rebuilt from the ground up with a focus on simplicity, performance, and a codebase with minimal technical debt.
https://mortii.github.io/anki-morphs/
GNU Affero General Public License v3.0
61 stars 9 forks source link

Tags in Note Filter does not seem to work. #42

Closed HQYang1979 closed 11 months ago

HQYang1979 commented 11 months ago

image

My workaround is add another filter.

mortii commented 11 months ago

Thank for the feedback!

What is your desired outcome? So for your 'Hanna English' cards, do you want to get the cards that have both 'Blue_Eyed_Samurai' AND 'Line_of_Duty_S1', or do you want the cards that have at least one of the tags?

HQYang1979 commented 11 months ago

On the old morphman, tags can be separated by a comma. the cards that have at least one of the tags will be filtered.

mortii commented 11 months ago

On AnkiMorphs it works like this:

if a note-filter has more than one tag (comma separated), then only cards that have all of those tags will be used

Note Type                   Tags            
1. note_type1               tag_a, tag_b

If you want cards that have either tag you have to do this:

Note Type                   Tags          
1. note_type1               tag_a  
2. note_type1               tag_b 

Your approach of having both tags on the same note-filter is definitely more intuative, and I'm sure everyone with a similar use-case will encounter this problem so we need to make the guide better and point this out explicitly.

It also occurs to me that note-filters can have significant overlap of cards and right now that would lead to them being recalculated more than one time. To fix this we would have to add a new check for that, something like:

if card_id in modified_cards:
    continue

I'll fix those things asap.

I personally only use one note-filter without any tags, so this was very helpful feedback, thank you so much!

mortii commented 11 months ago

@HQYang1979 btw, did you get names.txt to work?

mortii commented 11 months ago

I updated the tags guide, does it make sense? Any suggestions for making it better?

I'm terrible at writing guides, sorry!

HQYang1979 commented 11 months ago

@HQYang1979 btw, did you get names.txt to work?

yes, it works fine, thank you!

github-actions[bot] commented 8 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.