mortii / anki-morphs

A MorphMan fork rebuilt from the ground up with a focus on simplicity, performance, and a codebase with minimal technical debt.
https://mortii.github.io/anki-morphs/
Mozilla Public License 2.0
55 stars 8 forks source link

Japanese conjugation not as expected. #76

Closed HQYang1979 closed 9 months ago

HQYang1979 commented 9 months ago

image

HQYang1979 commented 9 months ago

image

HQYang1979 commented 9 months ago

it morphman, it will be the original unconjugated form.

Vilhelm-Ian commented 9 months ago

@HQYang1979 it parses the sentence the same way morphman does. It only puts the lemmatized form in the unknown field instead of the base form. To change this is really easy. The thing is would @mortii prefer to leave it like this or to change it. At the end of the day it shouldn't really change a lot with your reviews it's mostly an aesthethic thing. To let you which word is the target morph. A different approach you can take is to enable highlithing. Which will highlight the base word

HQYang1979 commented 9 months ago

@HQYang1979 it parses the sentence the same way morphman does. It only puts the lemmatized form in the unknown field instead of the base form. To change this is really easy. The thing is would @mortii prefer to leave it like this or to change it. At the end of the day it shouldn't really change a lot with your reviews it's mostly an aesthethic thing. To let you which word is the target morph. A different approach you can take is to enable highlithing. Which will highlight the base word

I see, I am satisfied knowing this.

HQYang1979 commented 9 months ago

I double checked, it is not working as you described. I press L for all the unknown morphs, but there are only the conjugated form, no original form are present.

@HQYang1979 it parses the sentence the same way morphman does. It only puts the lemmatized form in the unknown field instead of the base form. To change this is really easy. The thing is would @mortii prefer to leave it like this or to change it. At the end of the day it shouldn't really change a lot with your reviews it's mostly an aesthethic thing. To let you which word is the target morph. A different approach you can take is to enable highlithing. Which will highlight the base word

Vilhelm-Ian commented 9 months ago

@HQYang1979 i don't understand your complaint can you try to reword it. What do you want to happen. And why do you want it to be like that

HQYang1979 commented 9 months ago

@HQYang1979 i don't understand your complaint can you try to reword it. What do you want to happen. And why do you want it to be like that

Japanese, English, Spanish, they conjugates. やめる、やめます、やめました、やめれる take, took, taken, taking tomar, tomo, tomas, toman, tomé, tomado, tomaron, tome..... they are essentially same word but in different forms. In morphman, the K is only counting the original form (non conjugated form), and V is counting other derivatives.

When I press L, I finds only the conjugated form, in the case above, やめ, but not the non conjugated oringal form やめる.

So I am thinking ankimorph is counting やめるand やめseparately. Am I right? Please let me know if I am making sense.

Vilhelm-Ian commented 9 months ago

the K and V are calculated the same way they are in morphman. The issue you are experiencing is because what L does is open the browser with all the cards with the same word in "unknown_morph" field.

It's a simple fix like most things you mentioned. It depends if @mortii wants to change the design in that direction.

But the thing you are most likely concirned is K and V are counted the same as they are in morphman

mortii commented 9 months ago

So I am thinking ankimorph is counting やめるand やめ separately. Am I right? Please let me know if I am making sense.

やめる and やめ would give: U: 1 A: 2

When I press L, I finds only the conjugated form, in the case above, やめ, but not the non conjugated oringal form やめる.

'L' looks up the same derivative (inflected) version of the morph. I might be very familiar with やめる but I might not be familiar with やめ, so I want to only look at cards that have that version of the morph. If you were to look up every card that has a やめる derivative then that could be confusing and not very helpful in that scenario.

HQYang1979 commented 9 months ago

So I am thinking ankimorph is counting やめるand やめ separately. Am I right? Please let me know if I am making sense.

やめる and やめ would give: U: 1 A: 2

When I press L, I finds only the conjugated form, in the case above, やめ, but not the non conjugated oringal form やめる.

'L' looks up the same derivative (inflected) version of the morph. I might be very familiar with やめる but I might not be familiar with やめ, so I want to only look at cards that have that version of the morph. If you were to look up every card that has a やめる derivative then that could be confusing and not very helpful in that scenario.

This is good enough for me.

Another reason I would like the original form to be on the focus field is that I can copy and paste it in the original form, so that I can look it up directly on a dictionary without having to type the suffix, or paste it on the sorting field so I can do the merge card thing as shown in #82 .

mortii commented 9 months ago

Another reason I would like the original form to be on the focus field is that I can copy and paste it in the original form, so that I can look it up directly on a dictionary without having to type the suffix, or paste it on the sorting field so I can do the merge card thing as shown in #82 .

I don't like the idea of using the base form as a focus morph because it is lossy, i.e. you lose the context of how the morph is used in the card. That would be taking a step backwards compared to how it is done now, in my opinion.

As for dictionaries: when I type もらえたら in jisho and in ichi they both give me the correct root of 貰える

HQYang1979 commented 9 months ago

やめる and やめ would give: U: 1 A: 2

I just verified it to be a true. Thank you.

mortii commented 9 months ago

Hopefully I have successfully conveyed why I think the current AnkiMorphs implementation is superior to MorphMan. I will close this now.

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.