mortii / anki-morphs

A MorphMan fork rebuilt from the ground up with a focus on simplicity, performance, and a codebase with minimal technical debt.
https://mortii.github.io/anki-morphs/
Mozilla Public License 2.0
52 stars 7 forks source link

exclude cards with specific tags #83

Closed mortii closed 8 months ago

mortii commented 9 months ago

is it possible to exclude cards with specific tags...I mean the other way around

Originally posted by @HQYang1979 in https://github.com/mortii/anki-morphs/issues/81#issuecomment-1835424780

mortii commented 9 months ago

I have not thought about that before. Give me a couple of hours and I'll try to figure out of it is feasible or not.

Vilhelm-Ian commented 9 months ago

@mortii it's a simple fix just do this in the query -tag:am-known adding a - before query negates it

Vilhelm-Ian commented 9 months ago

I think we should be vary on how many settings we add to the addon. The biggest complaint people had with th original was that it was too difficult to use

HQYang1979 commented 9 months ago

This reason I proposed this is because I have these cards:

image

I would like to exclude these cards by tags.

Vilhelm-Ian commented 9 months ago

@HQYang1979 can't you manually bury them or suspend them. And if you need to review them put them in a different deck

Vilhelm-Ian commented 9 months ago

@HQYang1979 A problem with what you want is that in anki what tag one card has every card for the note type will have it. So if you plan on excluding a certain type of card from your note type it won't work

HQYang1979 commented 9 months ago

<@HQYang1979 A problem with what you want is that in anki what tag one card has every card for the note type will have it. So if you plan on excluding a certain type of card from your note type it won't work>

No, I can always add a new tag to the cards I want to exclude. This is what I did with Morphman, only that I did it to include instead of exclude.

Vilhelm-Ian commented 9 months ago

@HQYang1979 if you add a tag to a card you are also adding the tag to the NOTE.

Do you want to add tags to cards not in a note filter so they will be treted like they are in the note filter?

HQYang1979 commented 9 months ago

@HQYang1979 can't you manually bury them or suspend them. And if you need to review them put them in a different deck

This deck is actually very good material I downloaded from ankiweb, but it is in a messy format. What I do is try to modify it one by one. I've already put them in a different deck, but without excluding them, they will be analyzed.

So I am thinking if I can exclude them by tags....

Vilhelm-Ian commented 9 months ago

@HQYang1979 can't you delete or suspend those based on their tags.

HQYang1979 commented 9 months ago

Do you want to add tags to cards not in a note filter so they will be treted like they are in the note filter?

I see what you mean. Sorry for causing confusion. I use card and note pretty meaning the same thing.

HQYang1979 commented 9 months ago

@HQYang1979 can't you delete or suspend those based on their tags.

I suppose I can suspend them. Well, I might just find another work around.

mortii commented 9 months ago

I actually think this is a good feature suggestion, it can definitely be useful.

I think we should be vary on how many settings we add to the addon. The biggest complaint people had with th original was that it was too difficult to use

Completely agree. I think I can modify the new tag selector to make this minimally difficult and confusing. If it turns out to not be the case then we can always remove it.

Screenshot from 2023-11-30 17-42-32

aleksejrs commented 9 months ago

@mortii, there is a flat selector to select from all tags?! What about tag hierarchy? What about pattern matching? What about search among hundreds of top-level tags?

mortii commented 9 months ago

@mortii, there is a flat selector to select from all tags?! What about tag hierarchy? What about pattern matching? What about search among hundreds of top-level tags?

Those are all good features, but I don't want to spend a million years working on the tag selector. Maybe when everything else is completed. I really like the searching suggestion :+1:

mortii commented 8 months ago

@Vilhelm-Ian @HQYang1979 @aleksejrs

Screenshot from 2023-12-06 21-00-19

Thoughts on this? Is it too confusing?

Vilhelm-Ian commented 8 months ago

it looks pretty. Just make sure someone can't select to include and exclude the same time. I think radio buttons would make more sense

HQYang1979 commented 8 months ago

Can I search the tags? What if I have tons of tags...

aleksejrs commented 8 months ago

If the UI doesn't even know about hierarchical tags, it will be unusable. The 6304 "is:due" cards in my collection (out of 61039 "-is:new") have 2961 tags.

mortii commented 8 months ago

Added searchbar that supports regex Screenshot from 2023-12-07 12-34-02

mortii commented 8 months ago

If the UI doesn't even know about hierarchical tags, it will be unusable.

@aleksejrs I have no idea how hierarchical tags could be displayed in this kind of view.... collapsible rows would be weird I think... Is having a searchbar good enough?

mortii commented 8 months ago

make sure someone can't select to include and exclude the same time. I think radio buttons would make more sense

@Vilhelm-Ian yep, if one checkbox is selected the other one is automatically unselected. If we used radio buttons there would have to be three of them (exclude, include, none), so I think checkboxes is probably better.

mortii commented 8 months ago

make sure someone can't select to include and exclude the same time. I think radio buttons would make more sense

@Vilhelm-Ian yep, if one checkbox is selected the other one is automatically unselected. If we used radio buttons there would have to be three of them (exclude, include, none), so I think checkboxes is probably better.

I changed my mind, having radio buttons would make it more explicit that there are three options not just two... I'll try to implement that instead.

mortii commented 8 months ago

Screenshot from 2023-12-07 16-12-14

Suggestions for better column names? I don't love "None".

mortii commented 8 months ago

Let's continue in a discussion instead: #90