mortii / anki-morphs

A MorphMan fork rebuilt from the ground up with a focus on simplicity, performance, and a codebase with minimal technical debt.
https://mortii.github.io/anki-morphs/
Mozilla Public License 2.0
52 stars 7 forks source link

Add a way to see the number of unknown morphs on a note #92

Closed buster-blue closed 8 months ago

buster-blue commented 8 months ago

Is your feature request related to a problem? Please describe. I like to see how close a note is to being ready. It helps to give me motivation when I see more and more cards start to have lower unknown counts, and it lets me know how close I am to being able to learn specific notes.

Describe the solution you'd like Add an optional field in the "Extra Fields" section that's similar to the one Morphman has. Maybe call it something like "AM_unknown_count". If not that, then add some other way of seeing the number of unknown morphs on a note.

Describe alternatives you've considered N/A

Additional context Morphman has a field for this, and I liked it.

Vilhelm-Ian commented 8 months ago

@buster-blue what is the use case for this?

buster-blue commented 8 months ago

@Vilhelm-Ian

It helps to give me motivation when I see more and more cards start to have lower unknown counts, and it lets me know how close I am to being able to learn specific notes.

It also acts as a casual way to see if the notes I added for a certain source have a lot of words I don't know. But it's mostly that it feels nice to see the progress on an individual note that has many unknowns. It was cool to see this info in Morphman.

Vilhelm-Ian commented 8 months ago

It also acts as a casual way to see if the notes I added for a certain source have a lot of words I don't know.

You will be able to do that much easier using the upcoming readabliity analyzer feature(morphman has one).

Also for the motivation part. I get I also liked seeing unknown morphs part on the readability analyzer go down.

I just don't think there is a valid reason to add this feature.

buster-blue commented 8 months ago

You will be able to do that much easier using the upcoming readabliity analyzer feature(morphman has one).

I don't want to see the readability of text files that I have on my desktop. I never used the readability analyzer in Morphman. I want to see how close a note is to being ready, by seeing how many unknown morphs it has, and to be able to sort all the notes by how many unknowns they have to compare using field sorting. If those aren't considered valid enough reasons, then I'll accept that, but the readability analyzer isn't going to do what I want here, so it's not a solution for me.

Vilhelm-Ian commented 8 months ago

You want to get the motivation kick of knowing you are getting closer to understand a piece of media.

With the readability analyzer you can see how the number of unknown morphs is decreasing for a piece of media without having to check individual notes.

This project is mortii work. It all depends if he wants to implement it.

buster-blue commented 8 months ago

You want to get the motivation kick of knowing you are getting closer to understand a piece of media.

No. I want to know how close I am to being able to learn specific notes when they're ready. It's the notes themselves that I care about here, not the sources I use to make the notes.

This project is mortii work. It all depends if he wants to implement it.

I know that I'm owed nothing. This is a humble request to add a feature that I enjoyed in Morphman. The only way to know if he wants to implement it is by asking, so I created this issue to do just that. Nothing more.

Vilhelm-Ian commented 8 months ago

This project is mortii work. It all depends if he wants to implement it.

I know that I'm owed nothing. This is a humble request to add a feature that I enjoyed in Morphman. The only way to know if he wants to implement it is by asking, so I created this issue to do just that. Nothing more.

My point wasn't that you are not owned anything. We apreciate that you requested a feature. I wanted to say. The fact that I don't find it useful. Dosen't mean your feature won't be implemented.

I want to know how close I am to being able to learn specific notes

may I ask why do you want to know when you will be able to learn a specific note? You alrady mentioned motivation. But why does it intrest you.

Another question couldn't you just manually count the number of unknown morphs in the unknown field

HQYang1979 commented 8 months ago

Sorry to say that I don't understand the merits here. For both of the requests.

mortii commented 8 months ago

Is your feature request related to a problem? Please describe. I like to see how close a note is to being ready. It helps to give me motivation when I see more and more cards start to have lower unknown counts, and it lets me know how close I am to being able to learn specific notes.

Describe the solution you'd like Add an optional field in the "Extra Fields" section that's similar to the one Morphman has. Maybe call it something like "AM_unknown_count". If not that, then add some other way of seeing the number of unknown morphs on a note.

Describe alternatives you've considered N/A

Additional context Morphman has a field for this, and I liked it.

@buster-blue Thank you for the suggestion! I love seeing new people get involved with shaping the project :)

I always thought that option in MorphMan was pretty redundant since you could just look at the focus morphs and count them, but I never thought about the use case you described--sorting on the field in the browser could be useful.

Also for the motivation part. I get I also liked seeing unknown morphs part on the readability analyzer go down. I just don't think there is a valid reason to add this feature.

@Vilhelm-Ian I disagree with this. The add-on is meant to make language learning easier -> learning is easier if you are more motivated -> features that increase motivation are therefore valid.

Adding this will be pretty easy, so I will do it sometime in the near future!

buster-blue commented 8 months ago

You alrady mentioned motivation. But why does it intrest you.

Well aside from motivation, one more thing I would do sometimes is sort the cards to find the ones with the highest morphs, then check if I have other sentences with those morphs, so that I know that I'll be able to get those notes down to single-target, and if not I try to do something about it.

couldn't you just manually count the number of unknown morphs in the unknown field

Yes, but this means that I can't sort, so I have to manually look at each card, which would take an unreasonable amount of time when I have a little under 1000 new cards currently. Being able to sort makes it quick and easy.

Adding this will be pretty easy, so I will do it sometime in the near future!

Great to hear! Thanks!

HQYang1979 commented 8 months ago

Well aside from motivation, one more thing I would do sometimes is sort the cards to find the ones with the highest morphs, then check if I have other sentences with those morphs, so that I know that I'll be able to get those notes down to single-target, and if not I try to do something about it.

I understand now.

mortii commented 8 months ago

I want to see how close a note is to being ready, by seeing how many unknown morphs it has, and to be able to sort all the notes by how many unknowns they have to compare using field sorting.

@buster-blue could you provide the steps you do to accomplish this? I want to make sure I can reproduce it.

buster-blue commented 8 months ago

@mortii Sure. So basically I just added this field as one of the optional fields with Morphman that you could add, then when I would look at the cards, I'd have the "unknown morph count" field expanded by default, so I could see them. And when I'd want to sort by the field to compare them, I'd go to the browse page, and set that field as the sort field. It requires a full sync every time you do it which is annoying, but it does actually work, and it helps me see which notes are close to being ready, and which are far.

mortii commented 8 months ago

when I'd want to sort by the field to compare them, I'd go to the browse page, and set that field as the sort field

@buster-blue how do you do this part?

Edit: Do you use this option? Screenshot from 2023-12-11 15-12-06

mortii commented 8 months ago

Screenshot from 2023-12-11 15-27-36

What should the column header be? 'Number of unknowns' is a little lengthy, but that is fine i guess.

buster-blue commented 8 months ago

@mortii Yeah that's the option I use.

What should the column header be

"Number of Unknowns" works okay. For something shorter, "Unknown Count" is probably clear too.

Vilhelm-Ian commented 8 months ago

@Vilhelm-Ian I disagree with this. The add-on is meant to make language learning easier -> learning is easier if you are more motivated -> features that increase motivation are therefore valid.

I get that. But I don't get why he finds it motivating

mortii commented 8 months ago

I get that. But I don't get why he finds it motivating

It's just a different way of seeing progress in your card collection.

I get I also liked seeing unknown morphs part on the readability analyzer go down

It is just a transformed version of this. Both are perfectly valid imo.

mortii commented 8 months ago

"Number of Unknowns" works okay. For something shorter, "Unknown Count" is probably clear too.

@buster-blue It might just be an idiosyncrasy I have, but when I see 'unkowns count' it is not immediately understandable to me what it does, it takes me a couple of nano seconds to decipher it.

I added some other potential phrases:

Screenshot from 2023-12-11 16-29-04

How do you feel about '# of Unknowns'? I 'm not sure I like that any better though..

buster-blue commented 8 months ago

@mortii "# of Unknowns" is also okay. I find myself reading it as "ID of unknowns" at first for some reason, but it is the number sign so that's probably just me. "Unknowns sum" also works and I don't think it can be confused for anything.

mortii commented 8 months ago

@mortii "# of Unknowns" is also okay. I find myself reading it as "ID of unknowns" at first for some reason, but it is the number sign so that's probably just me. "Unknowns sum" also works and I don't think it can be confused for anything.

@buster-blue you're right, the # sign is very ambiguous. I'll just use 'Unknowns Count', I can't think of anything better.

mortii commented 8 months ago

Screenshot from 2023-12-12 13-05-02

Ok, I got it working. I'll push a new release soon.

mortii commented 8 months ago

The update is now live! Thanks for teaching me about the sorting option @buster-blue, it's super cool :)

github-actions[bot] commented 6 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.